[ticket/17606] Remove profile fields of defunct messaging services - #7003
Open
ECYaz wants to merge 1 commit into
Open
[ticket/17606] Remove profile fields of defunct messaging services#7003ECYaz wants to merge 1 commit into
ECYaz wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ICQ was shut down in 2024, Skype in 2025 and Yahoo Messenger already in 2018. Remove their default profile fields from new installations and, like the earlier AOL removal, drop the fields and their data from existing boards via migration. PHPBB-17606
Copy link
Copy Markdown
|
The attempt to merge branch 3.3.x into master has completed after considering the changes in this PR.
A separate PR will be needed to merge 3.3.x into master. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.3.x version of PR #7002. ICQ was shut down in 2024, Skype in 2025 and Yahoo Messenger already in 2018. This removes the three default profile fields from new installations and drops the fields, their data columns and their language rows from existing boards via a migration with full revert support, following the AOL removal that shipped in 3.3.2. The phpBB 2.0 convertor mappings for user_icq and user_yim and the contact icon sprite rules are removed as well.
The up-merge into master will conflict where the two implementations meet (convertor, colours.css, migration test); the resolution is the master companion PR #7002.
If the team would rather not remove functionality in 3.3.x maintenance at this point, closing this PR in favour of the master version is a fine outcome; opening both lets you make that call explicitly.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17606