[ticket/17668] Prevent managing special groups from the UCP - #7007
Open
ECYaz wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Group leaders of special groups could manage them from the UCP without any ACP permission check, allowing a leader of the Administrators group to add new admins. Special groups now have to be managed from the ACP, consistent with group descriptions which are already not editable for special groups in the UCP. Led special groups are no longer listed on the UCP manage groups page. PHPBB-17668
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17668
Group leaders could manage special groups from the UCP without any ACP permission check, so a leader of the Administrators group was able to add new admins. Special groups now have to be managed from the ACP and are no longer listed on the UCP manage groups page. The existing UCP group tests managed the Administrators group directly, they now use regular groups led by the admin user instead.