| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
This is still not installing Symfony 8. I fear that without Flex enforcing it, Composer prefers the stable version. |
Sorry, something went wrong.
|
Seeing https://github.com/phpbench/phpbench/actions/runs/19114176412/job/54631434251, I'm not sure to understand why it does not install Symfony 8 beta packages:
However, running composer require symfony/console ^8.0.0-BETA1 -W correctly install Symfony 8 beta packages. |
Sorry, something went wrong.
|
Because you're forcing Composer's SAT solver to use the beta; it seems that, if it's left with the choice, it prefers the stable tag. We need Flex and its forced requirement. |
Sorry, something went wrong.
|
Added Flex and updated the pinned version of shivammathur/setup-php. |
Sorry, something went wrong.
|
container 2.2.3 was tagged. still seems odd that Symfny seems to require a special tool to install it, given a choice I'd rather just composer require symfony/console $symfonyVersion in the pipeline. But it's fine to leave it as it is. |
Sorry, something went wrong.
Can you please restart the CI?
Flex does a lot more than that, because it locks down all Symfony components, so it influences indirect dependencies too. In the past I had issues without that because it can mix different major versions, leading to strange bugs in CI. |
Sorry, something went wrong.
|
ok, looks like we've uncovered actual incompatibilit(y|ies) now |
Sorry, something went wrong.
|
Application::add($command) is easily replaced with Application::addCommands([$command]) (notice the 1-element array). addCommands is available since ages and still available in 8, I did this same fix multiple times yesterday. |
Sorry, something went wrong.
|
Aaaand it's all green now, PHPBench can now fully run on Symfony 8 :) PS: I really like the bin/phpbench cats --profile=examples command 😻 |
Sorry, something went wrong.
|
awesome, thanks for this, will tag later today or tomorrow |
Sorry, something went wrong.
|
Perfect, thanks :) |
Sorry, something went wrong.
|
great job guys, thank you! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Follows #1125