FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Opcode counting executor by dantleech · Pull Request #904 · phpbench/phpbench · GitHub

Opcode counting executor - #904

Open
dantleech wants to merge 2 commits into
masterfrom
poc-opcode-counter
Open

Opcode counting executor#904
dantleech wants to merge 2 commits into
masterfrom
poc-opcode-counter

Conversation

dantleech commented Jul 31, 2021
edited
Loading

Copy link
Copy Markdown
Member
  • Adds opcode executor --executor=opcode
  • Show opcode count in aggregate report with stdev
  • Show opcode count in default (i.e. per-iteration) report.
  • Add option (enabled by default) to the expression report generator to hide columsn with missing vars (e.g. opcode count)
  • Move stuff around the executor hierarchy to enable more reuse 🙃
  • @deprecate the PARAM_SAFE_PARAMTER template-executor constant to force removal in 2.0
  • Allow opcode executor to be pre or post optimisation
  • Option to dump opcache output to path

TODO:

  • Reporting: maybe interesting to add a graph for opcode count.
  • Considering combining this into the default executor and adding an additional CLI option to enable it?
  • It is possible to use assertions with opcode counts?
  • Documentation...

dantleech force-pushed the poc-opcode-counter branch from 4f8964b to aa1ed36 Compare July 31, 2021 21:07
dantleech force-pushed the poc-opcode-counter branch 3 times, most recently from 519a643 to e515a93 Compare June 22, 2024 16:41
dantleech changed the title POC: Opcode counter Opcode counting executor Jun 22, 2024
dantleech force-pushed the poc-opcode-counter branch 4 times, most recently from 8502c67 to 8e34ac3 Compare June 22, 2024 17:02
namespace PhpBench\Expression\Exception;

class KeyDoesNotExist extends EvaluationError
class VariableNotFound extends EvaluationError

dantleech Jun 22, 2024
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

previously unused class, technically a B/C break but 🤷 -- although to be safe may as well deprecate it and create a new class.

- Show opcode count in aggregate report
- Throw specific exception when variable not found
- Show stdev on aggregate report
- Add option to expression-generator to hide columsn with missing vars
  (e.g. opcode count)
- Move stuff around the executor hierarchy to enable more reuse 🙃
- @deprecate the PARAM_SAFE_PARAMTER template-executor constant to force removal in 2.0
- Allow opcode executor to be pre or post optimisation
- Option to dump opcache output to path
- Test opcode dump for file with > 1000 lines

Test > 1000 lines
dantleech force-pushed the poc-opcode-counter branch from 8e34ac3 to f87176c Compare June 22, 2024 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL