FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use WixPSExtension to install PowerShell extension by mbiebl · Pull Request #44 · phpmanager/phpmanager · GitHub

This repository was archived by the owner on Mar 9, 2024. It is now read-only.
/ phpmanager Public archive

Use WixPSExtension to install PowerShell extension - #44

Merged
lextm merged 3 commits into
phpmanager:masterfrom
messageconcept:pssnapin
Apr 16, 2021
ConversationCommits (3)ChecksFiles changed
Merged

Use WixPSExtension to install PowerShell extension#44
lextm merged 3 commits into
phpmanager:masterfrom
messageconcept:pssnapin

Conversation

mbiebl commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

Instead of using a managed custom action and InstallUtil.exe, we vastly
simplify the installation using WixPSExtension.

Fixes: #33

mbiebl commented Mar 31, 2021

Copy link
Copy Markdown
Contributor Author

I have an alternative approach in messageconcept@dcd0f6c

Not sure which one you prefer. The Module based approach is more modern and generally the recommended method nowadays.

Let me know what you think.

mbiebl commented Mar 31, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

There are unrelated white space changes in this PR. So #43 should probably be merged first and I'll rebase this PR.

lextm commented Mar 31, 2021

Copy link
Copy Markdown
Member

For a legacy project, I really try to avoid huge pull requests like #43 which introduces nothing but source code format changes.

If possible, undo unnecessary line changes in this pull request.

mbiebl commented Mar 31, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

If possible, undo unnecessary line changes in this pull request.

Those are done automatically by Visual Studio. I can undo them manually, but this is kinda annoying having to do that every time I touch the file.
If you don't want to merge #43, would you be ok, if commits contain white space fixes for files that are touched by a PR?

mbiebl commented Mar 31, 2021

Copy link
Copy Markdown
Contributor Author

Anyway, will redo this commit to drop unnecessary white space changes. Feel free to close #43

If you'd prefer the Modules based approach over fixing the Snapin one, please let me know

mbiebl added 2 commits March 31, 2021 22:53
Use WixPSExtension to install PowerShell extension
5974004 
Instead of using a managed custom action and InstallUtil.exe, we vastly
simplify the installation using WixPSExtension.

Fixes: phpmanager#33
Update Powershell description
a0dadd5 
We support IIS 7 and above. Instead of explicitly mentioning any version
at all, just drop it, as IIS 6 is no longer really relevant.

mbiebl commented Mar 31, 2021

Copy link
Copy Markdown
Contributor Author

Force-Pushed with unnecessary white space changes removed.

Please have another look

Move PowerShell module help to a different component
d04b685 
It makes more sense to group it together with the PowerShell assembly
then with the license file.
lextm merged commit 70e4709 into phpmanager:master Apr 16, 2021
mbiebl mentioned this pull request Apr 16, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
lextm lextm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Add-PsSnapin PHPManagerSnapin

2 participants

Back | FazBrowse Home | New Git URL