Drop USE_UTF_STRINGS constant - #471
Merged
williamdes merged 1 commit intoJun 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Copy link
Copy Markdown
Codecov ReportPatch coverage: 100.00% and project coverage change: -0.01 ⚠️ Additional details and impacted files @@ Coverage Diff @@
## master #471 +/- ##
============================================
- Coverage 96.64% 96.64% -0.01%
+ Complexity 2213 2212 -1
============================================
Files 66 66
Lines 5096 5094 -2
============================================
- Hits 4925 4923 -2
Misses 171 171
☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Just so I remember, this needs to be removed from here as well https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/classes/Linter.php#L36 |
Sorry, something went wrong.
williamdes
approved these changes
Jun 5, 2023
williamdes
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you
Sorry, something went wrong.
williamdes
added a commit
that referenced
this pull request
Jun 5, 2023
Pull-request: #471 Signed-off-by: William Desportes <williamdes@wdes.fr>
kamil-tekiela
added a commit
to kamil-tekiela/phpmyadmin
that referenced
this pull request
Jun 7, 2023
phpmyadmin/sql-parser#471 Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The days of PHP 5.5 are long gone. A constant by its definition should never change value. I assume it was meant to be a config option, but of course we don't expect anyone to change some obscure line of code. So let's remove this code as it serves no purpose anymore.