Refactor build method - #483
Merged
MauricioFauth merged 2 commits intoAug 20, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportPatch coverage: 93.33% and project coverage change: -0.16% ⚠️ Additional details and impacted files @@ Coverage Diff @@
## master #483 +/- ##
============================================
- Coverage 96.61% 96.46% -0.16%
- Complexity 2173 2177 +4
============================================
Files 66 66
Lines 5054 5062 +8
============================================
Hits 4883 4883
- Misses 171 179 +8
☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
kamil-tekiela
force-pushed
the
Refactor-build-method
branch
from
c49303e to
19c5bfa
Compare
June 11, 2023 21:57
williamdes
marked this pull request as draft
June 17, 2023 18:33
Copy link
Copy Markdown
Member
|
I think it needs a rebase, I marked it as draft |
Sorry, something went wrong.
kamil-tekiela
force-pushed
the
Refactor-build-method
branch
2 times, most recently
from
44e5c60 to
ddb7a3f
Compare
July 27, 2023 10:50
kamil-tekiela
marked this pull request as ready for review
July 27, 2023 10:55
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
kamil-tekiela
force-pushed
the
Refactor-build-method
branch
from
ddb7a3f to
2930a89
Compare
August 17, 2023 14:28
MauricioFauth
approved these changes
Aug 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This overrides the previous two PRs.
This isn't even 50% of what I wanted to achieve but fixing this is really difficult. As I am going to be off of the internet for the next month, I will not have time to work on this.