FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add support for `ALTER FUNCTION` and `ALTER PROCEDURE` statements by niconoe- · Pull Request #553 · phpmyadmin/sql-parser · GitHub

/ sql-parser Public

Add support for ALTER FUNCTION and ALTER PROCEDURE statements - #553

Merged
williamdes merged 3 commits into
phpmyadmin:5.10.xfrom
niconoe-:feature/support-alter-routine
May 9, 2024
ConversationCommits (3)ChecksFiles changed
Merged

Add support for ALTER FUNCTION and ALTER PROCEDURE statements#553
williamdes merged 3 commits into
phpmyadmin:5.10.xfrom
niconoe-:feature/support-alter-routine

Conversation

niconoe- commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

Add support for ALTER FUNCTION and ALTER PROCEDURE statements.

The ABNF for those statements are exactly the same since MySQL 5.0 to latest MariaDb version:

2 commits are done: the first with everything but the options definitions in case of ALTER PROCEDURE or ALTER FUNCTION, causing all *.out data files giving the error "Unrecognized alter operation." we are trying to solve. The second commit applies the options definitions, so you can see that the related *.out files are updated to no longer have the parser error, but the full options built instead.

@williamdes It's been a long time 😄 . I'll not be back for so long, but I never come back with empty hands 😆 .

codecov Bot commented Mar 1, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.79%. Comparing base (716d545) to head (edc7db8).
Report is 4 commits behind head on 5.9.x.

Additional details and impacted files 
@@            Coverage Diff            @@
##              5.9.x     #553   +/-   ##
=========================================
  Coverage     96.79%   96.79%           
- Complexity     2257     2259    +2     
=========================================
  Files            69       69           
  Lines          5172     5174    +2     
=========================================
+ Hits           5006     5008    +2     
  Misses          166      166

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

williamdes approved these changes Mar 6, 2024
View reviewed changes

williamdes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you, this all looks good to me
@kamil-tekiela what do you think ?

williamdes requested a review from MauricioFauth March 6, 2024 21:44
kamil-tekiela approved these changes Mar 6, 2024
View reviewed changes

kamil-tekiela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It looks fine.

williamdes added this to the 5.10.0 milestone Mar 6, 2024

niconoe- commented Mar 7, 2024

Copy link
Copy Markdown
Contributor Author

I'm glad you valid this 🙂

I'm having the Benchmark on PHP 8.0 not passing, but I don't understand why. Is this a blocking point preventing this PR to be merged? If yes, how can I handle this please?

Thanks a lot!

williamdes changed the title Feature/support alter routine Add support for ALTER FUNCTION and ALTER PROCEDURE statements May 9, 2024
williamdes self-assigned this May 9, 2024
williamdes changed the base branch from 5.9.x to 5.10.x May 9, 2024 08:26
williamdes merged commit 896b02e into phpmyadmin:5.10.x May 9, 2024
niconoe- deleted the feature/support-alter-routine branch August 6, 2024 15:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

williamdes williamdes approved these changes
MauricioFauth Awaiting requested review from MauricioFauth
+1 more reviewer
kamil-tekiela kamil-tekiela approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

williamdes

Labels

None yet

Projects

None yet

Milestone

5.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL