FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix query flags for lower-case functions by MoonE · Pull Request #564 · phpmyadmin/sql-parser · GitHub

/ sql-parser Public

Fix query flags for lower-case functions - #564

Merged
williamdes merged 1 commit into
phpmyadmin:5.10.xfrom
MoonE:fix-count-query-flags-lower-case
Aug 26, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Fix query flags for lower-case functions#564
williamdes merged 1 commit into
phpmyadmin:5.10.xfrom
MoonE:fix-count-query-flags-lower-case

Conversation

MoonE commented Jul 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

See phpmyadmin/phpmyadmin#16869

is_func and is_count were only set when the function is in all upper case.

MoonE force-pushed the fix-count-query-flags-lower-case branch from 32cd6d0 to a4f7166 Compare July 3, 2024 23:10

codecov Bot commented Jul 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.79%. Comparing base (716d545) to head (a4f7166).
Report is 6 commits behind head on 5.9.x.

Additional details and impacted files 
@@            Coverage Diff            @@
##              5.9.x     #564   +/-   ##
=========================================
  Coverage     96.79%   96.79%           
- Complexity     2257     2258    +1     
=========================================
  Files            69       69           
  Lines          5172     5175    +3     
=========================================
+ Hits           5006     5009    +3     
  Misses          166      166

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MoonE mentioned this pull request Jul 3, 2024
Closed
williamdes approved these changes Jul 4, 2024
View reviewed changes

williamdes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@iifawzi

williamdes commented Jul 4, 2024

Copy link
Copy Markdown
Member

Not sure why benchmarks are not passing

iifawzi commented Jul 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

it's unexpectedly faster? What these numbers are based on?

williamdes commented Jul 4, 2024

Copy link
Copy Markdown
Member

it's unexpectedly faster? What these numbers are based on?

Oh, on what I had when I wrote the bench. Maybe we can update to quicker then

Fix query flags for lower-case functions
35ca80b 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
MoonE force-pushed the fix-count-query-flags-lower-case branch from a4f7166 to 35ca80b Compare July 4, 2024 18:32
MauricioFauth changed the base branch from 5.9.x to 5.10.x July 22, 2024 18:46
williamdes added a commit that referenced this pull request Aug 26, 2024
Add a CHANGELOG entry for #564
456d946
williamdes merged commit d8e30bc into phpmyadmin:5.10.x Aug 26, 2024
williamdes self-assigned this Aug 26, 2024
williamdes added this to the 5.10.0 milestone Aug 26, 2024
MoonE deleted the fix-count-query-flags-lower-case branch August 26, 2024 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

williamdes williamdes approved these changes
+1 more reviewer
iifawzi iifawzi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

williamdes

Labels

None yet

Projects

None yet

Milestone

5.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL