Fix #434 - No error when using UPDATE ... SET - #577
Merged
MauricioFauth merged 6 commits intoAug 29, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Could you please target 5.10.x instead of 5.9.x? Thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Done, but the bug will remain in 5.9.x after the merge… Or do you plan to release a 5.10.0 soon ? 😇 😋 |
Sorry, something went wrong.
williamdes
approved these changes
Aug 27, 2024
Copy link
Copy Markdown
Contributor
Author
|
I updated the fix because it caused failures in SET operations out of an update statement context (like SET NAMES …). Now, that's ok 😃 . (except a linter in PHP 7.4 which is out of the scope of this PR 🤷 ). |
Sorry, something went wrong.
williamdes
reviewed
Aug 27, 2024
Comment thread
src/Statements/UpdateStatement.php
Outdated
williamdes
reviewed
Aug 27, 2024
Comment thread
src/Statements/UpdateStatement.php
Outdated
MauricioFauth
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #434
@williamdes / @iifawzi / @MauricioFauth / @liviuconcioiu
This should also be fixed in 5.10.x and master. How do you want me to proceed to perform this?