Switch from keydb to dragonfly in CI - #2907
Draft
michael-grunder wants to merge 4 commits into
Draft
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
KeyDB is no longer under active development but Dragonfly is so it makes more sense to test against Dragonfly instead.
There are a few edge cases where Dragonfly has slightly different functionality or returns a slightly different RESP shape. I'll open an issue with them to see whether they want to be more compatible. In the meantime they're pretty rare edge cases so we can handle them here so we can run the vast majority of tests against Dragonfly now.
michael-grunder
force-pushed
the
ci/keydb-to-dragonfly
branch
from
0bfde25 to
7a0e05a
Compare
August 14, 2026 18:24
We've got a generic multibulk handler that didn't handle elements that were non-strings. This seems like a bug in general but also fixes it so that our reply handler works for `TIME` in both `Redis` and `Dragonfly`
This fixes a test failure when running against Dragonfly but is also an improvement over just using PHPREDIS_CTX_PTR variants to figure out what the reply handler should do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeyDB is no longer actively maintained but dragonfly is so switch from testing against keydb to testing against dragonfly.