Addition of rule for cases better represented with assertSameSize() method - #207
o0h wants to merge 3 commits into
Conversation
Sorry, something went wrong.
ondrejmirtes
left a comment
There was a problem hiding this comment.
Hi,
this should only be reported with bleeding edge. Use private bool $bleedingEdge in the rule constructor and add the new behaviour only when this is true. Here's an example how it should look in config: https://github.com/phpstan/phpstan-doctrine/blob/0d967379b8ea58c4f4499b17eeb9f29718350497/rules.neon#L57
Sorry, something went wrong.
|
Hi, @ondrejmirtes! Thanks for the quick feedback! I'll be sure to use the bleeding edge flag as you suggested. Just hang tight a little longer! Best regards, |
Sorry, something went wrong.
Expanded the AssertSameWithCountRule in PHPUnit rules to handle additional scenarios. Now the rule checks if both sides of the assertSame are counts, and suggests assertSameSize instead when necessary. The modification enhances the rule's applicability and accuracy.
|
I have completed the necessary corrections that were of concern. |
Sorry, something went wrong.
The link in the README file's "bleeding edge" reference has been updated to accurately direct users to the relevant blog post. Also corrected the typo by capitalizing the initial letter of the sentence.
| } | ||
|
|
||
| if ( | ||
| $right instanceof Node\Expr\MethodCall |
There was a problem hiding this comment.
TBH this diff is very messy. I can't tell if the no-bleedingEdge behaviour is preserved or not. Can you split the changes in multiple commits? First extract logic into isCount... methods without changing the behaviour, and then introduce bleedingEdge-on behaviour that will be a new separate if statement. Can you please do that? Thank you.
Sorry, something went wrong.
Reviewers
Requested changes must be addressed to merge this pull request.
This Pull Request enhances the AssertSameWithCountRule in PHPUnit to handle additional use cases. The new rule now checks when both sides of the assertSame are counts, and suggests assertSameSize instead when necessary.
Here is some detail on what has changed:
The code changes involve adjustments in method call structures, evaluation of counts and introduction of cases for assertSameSize.