Implement AttributeRequiresPhpVersionRule - #268
Merged
ondrejmirtes merged 4 commits intoDec 5, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
staabm
marked this pull request as ready for review
December 5, 2025 07:30
staabm
commented
Dec 5, 2025
Comment thread
tests/Rules/PHPUnit/data/requires-php-version.php
|
|
||
| class DeprecatedVersionFormat extends TestCase | ||
| { | ||
| #[RequiresPhp('8.0')] |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
in a followup I want to emit errors when the version contstraint used within #[RequiresPhp('8.0')] does not fit into the php version used for analysis (detecting tests which require php-versions no longer supported in the project)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
implemented in #269
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Yeah, this is really needed, I made this mistake a few times myself. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using #[RequiresPhp('8.3')] without a version operator like >=, ^ or similar is deprecated as of PHPUnit 12.4 and was removed in PHPUnit 13.0
refs sebastianbergmann/phpunit#6355