Prevent global side-effect in Bug13813IntegrationTest - #4566
Merged
ondrejmirtes merged 2 commits intoNov 19, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
staabm
marked this pull request as ready for review
November 19, 2025 09:16
Copy link
Copy Markdown
Collaborator
|
This pull request has been marked as ready for review. |
Sorry, something went wrong.
ondrejmirtes
requested changes
Nov 19, 2025
Comment thread
tests/PHPStan/Analyser/Bug13813IntegrationTest.php
Outdated
| ); | ||
| } | ||
|
|
||
| error_reporting($oldReporting); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think the:
$analyzerResult = $this->runAnalyse([
__DIR__ . '/data/bug-13813.php',
__DIR__ . '/Bug13813Rule.php',
]);should be wrapped in a try-finally block and the restore be done there.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.