Correct GearmanClient unique parameters - #6241
Conversation
Sorry, something went wrong.
- Marks `unique=` as `?string` on `addTask*` and `do*` methods The ext-gearman signatures accept null for the optional unique key, so passing null was flagged as an error.
There was a problem hiding this comment.
Pull request overview
Updates PHPStan’s internal functionMap.php signature metadata for the Gearman extension so that GearmanClient methods reflect that the unique argument is nullable where the PHP manual documents it as such (unique = null).
Changes:
- Marked unique= as ?string for GearmanClient::addTask* methods.
- Marked unique= as ?string for GearmanClient::do* methods (excluding deprecated GearmanClient::do, as noted in the PR description).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
| 'GearmanClient::clone' => ['GearmanClient'], | ||
| 'GearmanClient::context' => ['string'], | ||
| 'GearmanClient::data' => ['string'], | ||
| 'GearmanClient::do' => ['string', 'function_name'=>'string', 'workload'=>'string', 'unique='=>'string'], |
There was a problem hiding this comment.
GearmanClient::do does not accept ?string, omitted from the changes.
Sorry, something went wrong.
|
I suspect the failing CI is nothing to do with me from what I can tell? |
Sorry, something went wrong.
Marks unique= as ?string on GearmanClient::addTask* and GearmanClient::do* methods
You can check the individual definitions -
For whatever reason, GearmanClient::do does not accept ?string and was omitted from the changes, but GearmanClient::do() method is deprecated so nbd