FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add `tablespace` argument to `Table` by dantownsend · Pull Request #527 · piccolo-orm/piccolo · GitHub

add tablespace argument to Table - #527

Draft
dantownsend wants to merge 4 commits into
masterfrom
526-tablespaces
Draft

add tablespace argument to Table#527
dantownsend wants to merge 4 commits into
masterfrom
526-tablespaces

Conversation

Copy link
Copy Markdown
Member

Closes #526

dantownsend added the enhancement New feature or request label May 24, 2022

codecov-commenter commented May 24, 2022
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.74%. Comparing base (a89c2fa) to head (18711cc).
⚠️ Report is 433 commits behind head on master.

Files with missing lines Patch % Lines
piccolo/query/methods/create.py 50.00% 1 Missing ⚠️
piccolo/query/methods/create_index.py 80.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
- Coverage   90.75%   90.74%   -0.02%     
==========================================
  Files         104      104              
  Lines        7010     7020      +10     
==========================================
+ Hits         6362     6370       +8     
- Misses        648      650       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member Author

This is pretty much done, but need to work out how to run the unit tests on a Postgres database which uses a custom tablespace.

Copy link
Copy Markdown

Hi Dan,

need to work out how to run the unit tests on a Postgres database which uses a custom tablespace

This is pretty easily done with testcontainers, which would also simplify test running in general. I set up a PR to do exactly that: #1410

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for tablespaces

3 participants


Back | FazBrowse Home | New Git URL