Make it possible to use multiple tokens. - #186
Conversation
Sorry, something went wrong.
This commit is based on the work of @valentinschabschneider and updated to the latest master branch. deckweiss@9653c35#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80 Fixes piceaTech#104.
|
This looks good to me and very useful if one is migrating a repository which is in use and has multiple collaborators. @spruce |
Sorry, something went wrong.
spruce
left a comment
There was a problem hiding this comment.
I like the changes. Except some leftover comments. If those will be removed, I'm happy.
Sorry, something went wrong.
| settings.github.token_owner) || | ||
| author.username === settings.github.token_owner) | ||
| this.githubApis[settings.usermap[author.username as string]]) || | ||
| // settings.usermap[author.username as string] === |
There was a problem hiding this comment.
Can you remove the comments. So we don't clutter the codebase
Sorry, something went wrong.
| settings.github.token_owner) || | ||
| note.author.username === settings.github.token_owner; | ||
| let userIsPoster = this.userTokenAvailable(note.author); | ||
| // (settings.usermap && |
There was a problem hiding this comment.
Remove these please, too.
Sorry, something went wrong.
| mergeRequest, | ||
| !this.userIsCreator(mergeRequest.author) || !settings.useIssueImportAPI | ||
| !this.userTokenAvailable(mergeRequest.author) // || | ||
| //!settings.useIssueImportAPI |
There was a problem hiding this comment.
This one as well.
Sorry, something went wrong.
|
Thank you for the nice PR! We try to use this PR for migrating our Issues from GitLab to GitHub. Using multiple tokens to connect user accounts seems to work as expected without using the IssueImportAPI (migrated issues and comments belong to the correct users). However, only the Issue creator is correct when using IssueImportAPI: true. All subsequent migrated comments on a migrated issue belong to the creator, not the original commentator. |
Sorry, something went wrong.
This PR is based on the work of @valentinschabschneider and updated to the latest master branch:
deckweiss@9653c35#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80
Fixes #104.