Improve path support - #60
Merged
pichillilorenzo merged 1 commit intoJun 10, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
Thanks @dnicolson! However I don't know if there could be some edge cases! |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
Hey @dnicolson, I want ask you if you want help me develop this project! I'm searching for members that want help me in their spare time! See #51 for details 😄. Thanks anyway! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes some code from the SublimeFixMacPath project in favour of using shellenv which is a Package Control dependency.
Currently when using the fish shell this package can break others that depend on the PATH environment variable. Initially a change was made (#59) to support the fish shell but it did not work as expected. In the original project fish support was added (int3h/SublimeFixMacPath#7) but broken soon after (int3h/SublimeFixMacPath@fecd771).
It is very likely more code can be removed by using shellenv, but there could be some edge cases @pichillilorenzo?