BUG: FIX Pipeline.update_defaults with inputs that do not support __eq__ - #857
Merged
basnijholt merged 3 commits intoJul 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… cannot be compared but let validation still pass
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests.
|
Sorry, something went wrong.
Copy link
Copy Markdown
CodSpeed Performance ReportMerging #857 will not alter performanceComparing LennartGevers:pipefunc_fix_validation_bug (495cd8f) with main (0e22cc1) Summary✅ 6 untouched benchmarks |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match the correct format. Thank you! |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Awesome @LennartGevers! Thanks a lot for implementing this and for fixing it. I've just pushed a small change to add more detail to the warning message. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to resolve #856 I put the comparison of default values in a try/except. If the default values cannot be compared, a warning will be emitted.