BUG: Fix CI failure on Python 3.13/3.14 with numpy 2.4.0+ - #929
Merged
basnijholt merged 1 commit intoJan 5, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Catch ValueError in addition to TypeError in _is_np_subdtype(). Newer numpy versions raise ValueError instead of TypeError when passing type annotations like npt.NDArray[np.int_] to np.issubdtype().
Copy link
Copy Markdown
Contributor
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match the correct format. Thank you! |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests.
|
Sorry, something went wrong.
Copy link
Copy Markdown
CodSpeed Performance ReportMerging #929 will not alter performanceComparing fix-numpy-issubdtype-valueerror (8ce628a) with main (53638a0) Summary✅ 6 untouched |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan