FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ENH: harden persisted run status error handling by basnijholt · Pull Request #940 · pipefunc/pipefunc · GitHub

ENH: harden persisted run status error handling - #940

Merged
basnijholt merged 2 commits into
mainfrom
fix-run-status-error-handling
Mar 6, 2026
Merged

ENH: harden persisted run status error handling#940
basnijholt merged 2 commits into
mainfrom
fix-run-status-error-handling

Conversation

Copy link
Copy Markdown
Collaborator

Summary

  • return status="error" for broken persisted metadata instead of mislabeling it as missing
  • make status_from_run_folder() and pipefunc-cli status return JSON errors instead of raising on malformed storage metadata
  • keep heartbeat-backed status readable when disk output metadata cannot be merged, and cover the new paths with real run-folder tests

Verification

  • uv run pytest tests/test_run_status_cli.py tests/test_mcp.py -q
  • uv run pytest -n 0 --cov=pipefunc._run_status --cov=pipefunc._run_status_heartbeat --cov=pipefunc._run_status_cli --cov-report term-missing tests/test_run_status_cli.py
  • uv run ruff check pipefunc/_run_status.py tests/test_run_status_cli.py

Notes

  • uv run mypy pipefunc/_run_status.py tests/test_run_status_cli.py in the fresh worktree hit unrelated missing-stub baseline errors outside this change (pipefunc/cache.py, pipefunc/_widgets/output_tabs.py), so I did not use it as a gate for this follow-up PR.

codecov Bot commented Mar 6, 2026
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
pipefunc/_run_status.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

basnijholt changed the title fix: harden persisted run status error handling ENH: harden persisted run status error handling Mar 6, 2026
basnijholt merged commit 0c4637a into main Mar 6, 2026
17 of 19 checks passed
basnijholt deleted the fix-run-status-error-handling branch March 6, 2026 18:57

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

✅ PR Title Formatted Correctly

The title of this PR has been updated to match the correct format. Thank you!

codspeed-hq Bot commented Mar 6, 2026
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing fix-run-status-error-handling (fb53b6f) with main (cd58b8d)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL