FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

MAINT: Restore NumPy 2.5 CI compatibility by basnijholt · Pull Request #976 · pipefunc/pipefunc · GitHub

MAINT: Restore NumPy 2.5 CI compatibility - #976

Merged
basnijholt merged 2 commits into
mainfrom
fix-numpy-2-5-ci
Jul 19, 2026
Merged

MAINT: Restore NumPy 2.5 CI compatibility#976
basnijholt merged 2 commits into
mainfrom
fix-numpy-2-5-ci

Conversation

basnijholt commented Jul 19, 2026
edited
Loading

Copy link
Copy Markdown
Collaborator

Problem

Recent dependency releases exposed three CI compatibility problems:

  • The pre-commit mypy hook targets Python 3.11 but, because the hook itself runs on Python 3.14, resolved NumPy 2.5.1. NumPy 2.5 no longer supports Python 3.11 and its stubs use Python 3.12 type syntax, so mypy rejected the dependency before checking the project.
  • NumPy 2.5 changed numpy.typing.NDArray to a generic alias with Any as its default scalar type. The existing test expected the pre-2.5 alias representation and failed throughout the uv minimal-dependency matrix.
  • The latest nh3, Pillow, and SciPy releases no longer publish wheels for the experimental Python 3.13 free-threaded ABI. The all-dependency job consequently attempted unsupported or fragile source builds.

These failures currently affect unrelated PRs, including #971, #973, and #975.

Solution

  • Constrain only the mypy hook environment to numpy<2.5, matching mypy's configured Python 3.11 target. The package's runtime NumPy dependency remains unpinned and continues to test against NumPy 2.5.
  • Make the NDArray[Any] compatibility assertion account for both the pre-2.5 parameterized alias and NumPy 2.5's defaulted generic alias.
  • Keep only the Python 3.13t nox environment on the newest releases that still provide compatible wheels. Other Python environments remain unconstrained.

Verification

  • pre-commit run --all-files — passed
  • Typing suite with locked NumPy 2.3.4 — 91 passed
  • Typing suite with NumPy 2.5.1 — 91 passed
  • Python 3.12 minimal environment with NumPy 2.5.1 — 1008 passed, 109 skipped, 2 xfailed
  • Python 3.13t minimal environment with NumPy 2.5.1 — 1007 passed, 110 skipped, 2 xfailed
  • Python 3.13t all-dependency environment — 1323 passed, 63 skipped, 2 xfailed

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codspeed-hq Bot commented Jul 19, 2026
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing fix-numpy-2-5-ci (16455f4) with main (cc84ed9)

Copy link
Copy Markdown
Contributor

✅ PR Title Formatted Correctly

The title of this PR has been updated to match the correct format. Thank you!

basnijholt merged commit ed4fb92 into main Jul 19, 2026
22 checks passed
basnijholt deleted the fix-numpy-2-5-ci branch July 19, 2026 19:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL