FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(schema): require type for composable image stack in platformsh schema by spk · Pull Request #264 · platformsh/platformify · GitHub

fix(schema): require type for composable image stack in platformsh schema - #264

Open
spk wants to merge 2 commits into
mainfrom
fix/platformsh-composable-image-type-required
Open

fix(schema): require type for composable image stack in platformsh schema#264
spk wants to merge 2 commits into
mainfrom
fix/platformsh-composable-image-type-required

Conversation

spk commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Mirrors the upsun.json change from Update upsun.json #258 to platformsh.application.json: type is now required when using composable image stack
  • Switches the top-level oneOf to anyOf so documents with both type and stack validate correctly (with oneOf, both branches would be satisfied simultaneously, causing a validation error)
  • Adds Test_validatePlatformConfig with cases for: simple type-only app, missing required fields, stack with type (valid), and stack without type (error)

Test plan

  • stack with type passes validation
  • stack without type fails validation
  • All existing tests still pass

spk added 2 commits June 9, 2026 08:59
…msh schema

When using composable image stack, type is now required to be consistent
with the upsun.json schema change in #258. Also switches the top-level
oneOf to anyOf so that documents with both type and stack satisfy the
schema correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL