Adds image property (object with name string) to the application schema in upsun.json
Adds image to the x-order list after stack
Adds a test case external-oci-image covering an app + Gotenberg OCI service configuration
Context
Applications using type: external:0.2 require an image.name property to specify the OCI container image (e.g. gotenberg/gotenberg:latest). Without this fix, upsun lint rejects the config with:
applications.<name>: Additional property image is not allowed
Test plan
New test external-oci-image fails before the schema change
All 15 tests pass after the schema change (go test ./validator/...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Applications using type: external:0.2 require an image.name property to specify the OCI container image (e.g. gotenberg/gotenberg:latest). Without this fix, upsun lint rejects the config with:
Test plan