Report missing dependencies with an actionable message - #130
Open
kbond wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.
📢 Thoughts on this report? Let us know! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgetting vendor/bin/playwright-install after composer require currently gets you DisconnectedException: Process exited with code 1. The Node stderr explaining why is read in ProcessJsonRpcClient and then only logged as a warning.
This includes that stderr in the exception, and recognises three setup problems as a new MissingDependencyException:
Playwright detects the last two itself but points at npx playwright install / install-deps; its original output is kept below ours. Also fixes ServerFinder::findServer(), which threw NetworkException('… npm install playwright').
Detection is by substring match on Playwright's messages.