Feature/logger - #83
Open
gimler wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gimler
commented
Mar 5, 2026
Comment thread
src/Browser/BrowserContext.php
Outdated
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
📢 Thoughts on this report? Let us know! |
Sorry, something went wrong.
stloyd
reviewed
Mar 7, 2026
Comment thread
src/Page/Page.php
| private readonly string $pageId, | ||
| private readonly PlaywrightConfig $config, | ||
| private readonly LoggerInterface $logger = new NullLogger(), | ||
| ?LoggerInterface $logger = null, |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
I would remove it from here and use only the one from config, and in confing spawn the null one by default.
Sorry, something went wrong.
smnandre
reviewed
Jun 2, 2026
Comment thread
src/Page/Page.php
| private readonly LoggerInterface $logger = new NullLogger(), | ||
| ?LoggerInterface $logger = null, | ||
| ) { | ||
| $this->logger = $logger ?? $config->logger ?? new NullLogger(); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Could you update doc/docblock on this ? Or do we consider this a bug?
Sorry, something went wrong.
smnandre
reviewed
Jun 2, 2026
Comment thread
src/Page/Page.php
|
|
||
| private PageEventHandlerInterface $eventHandler; | ||
|
|
||
| private LoggerInterface $logger; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| private LoggerInterface $logger; | |
| private readonly LoggerInterface $logger; |
maybe
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When i set a logger with PlaywrightConfig my expection is that is used also in Page and locator.
$log = new Logger('stdout'); $log->pushHandler(new StreamHandler('php://stdout', Logger::DEBUG)); $playwrightConfig = new PlaywrightConfig( logger: $log, ); $playwright = PlaywrightFactory::create($playwrightConfig);before
now i see in my log
[2026-03-05T09:31:22.553611+01:00] stdout.DEBUG: Navigating to URL {"url":"https://host.local/","options":[]} [] [2026-03-05T09:31:23.210677+01:00] stdout.INFO: Successfully navigated to URL {"url":"https://host.local/"} [] [2026-03-05T09:31:26.109054+01:00] stdout.ERROR: locator.isVisible: Error: strict mode violation: locator('button') resolved to 2 elements: 1) ... [05-Mar-2026 09:31:31 Europe/Berlin] PHP Fatal error: Uncaught Playwright\Exception\TimeoutException: Element not actionable (timeout: 30000ms) in /var/www/sap_et/vendor/playwright-php/playwright/src/Locator/Locator.php:666