Rewriting Async API in ImageExport - #321
Merged
kMutagene merged 2 commits intoJul 11, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
WhiteBlackGoose
marked this pull request as ready for review
July 9, 2022 05:58
kMutagene
reviewed
Jul 11, 2022
Comment thread
tests/Plotly.NET.ImageExport.Tests/ImageExport.fs
Outdated
| testBase64PNG | ||
| "Invalid base64 string for Chart.toBase64PNGStringAsync" | ||
| } | ||
| testCase "Chart.toBase64JPGString" <| fun () -> |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
This is a great idea, as we can at least test if the render engine finishes this way. could you add this for the other image formats as well? maybe rename the tests to Chart.toBase64PNGStringAsync terminates etc
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short explanation on the workaround.
Plus moved Async API to Task and Task<T> instead of F#'s Async, which makes it more convenient for C# users, and doesn't make it less convenient for F# users (aka pareto improvement 😆 )
Closes #320
Closes #306