FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix misaligned slider marks with empty labels by terminalchai · Pull Request #3723 · plotly/dash · GitHub

/ dash Public

Fix misaligned slider marks with empty labels - #3723

Merged
KoolADE85 merged 4 commits into
plotly:devfrom
terminalchai:fix-slider-mark-height
Apr 10, 2026
ConversationCommits (4)ChecksFiles changed
Merged

Fix misaligned slider marks with empty labels#3723
KoolADE85 merged 4 commits into
plotly:devfrom
terminalchai:fix-slider-mark-height

Conversation

terminalchai commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add an explicit height: 12px to .dash-slider-mark so empty labels keep the same mark box height as labeled marks
  • add an integration regression test covering the empty-string marks case from #3715
  • add the corresponding unreleased changelog entry

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • add the slider mark height fix
    • add a regression test for empty mark labels
    • add the changelog entry
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

Fixes #3715

AnnMarieW commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator

Thanks! Looks good.

AnnMarieW commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator

Just needs a changelog entry

terminalchai commented Apr 8, 2026

Copy link
Copy Markdown
Contributor Author

Added the unreleased changelog entry and updated the PR checklist accordingly.

KoolADE85 approved these changes Apr 10, 2026
View reviewed changes

KoolADE85 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the fix, it's looking good to me.

KoolADE85 merged commit 1fbfbac into plotly:dev Apr 10, 2026
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

KoolADE85 KoolADE85 approved these changes
T4rk1n Awaiting requested review from T4rk1n
ndrezn Awaiting requested review from ndrezn
camdecoster Awaiting requested review from camdecoster

Assignees

KoolADE85

Labels

no-issue-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bad behaviour] dcc.Slider marks misaligned with empty label in Dash 4

5 participants

Back | FazBrowse Home | New Git URL