fixes aggressive remounting - #3934
Open
BSd3v wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
BSd3v
requested review from
KoolADE85,
T4rk1n,
camdecoster and
ndrezn
as code owners
July 31, 2026 19:44
Copy link
Copy Markdown
|
Sorry, something went wrong.
KoolADE85
approved these changes
Aug 7, 2026
KoolADE85
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good catch, such a sneaky issue!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes:
Issue was that on the first render of a component, it would trigger it to remount and clear the layoutHashes since it wasnt protected to see if it was the very first time that the component was rendering.