FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed typo - calculcations of shared Y axis was using X axes by okhoma · Pull Request #1848 · plotly/plotly.R · GitHub

Fixed typo - calculcations of shared Y axis was using X axes - #1848

Open
okhoma wants to merge 1 commit into
plotly:masterfrom
okhoma:master
Open

Fixed typo - calculcations of shared Y axis was using X axes#1848
okhoma wants to merge 1 commit into
plotly:masterfrom
okhoma:master

Conversation

okhoma commented Sep 8, 2020

Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Collaborator

Thanks, do you have minimal example(s) that demonstrate the fix (better yet, can you add some unit test(s))?

okhoma commented Sep 17, 2020

Copy link
Copy Markdown
Author

@cpsievert, Is it really just a copy/paste error. It's only effect, as far as I can tell, is a warning:

p <- lapply(c("A", "B", "C"), function(x) plot_ly(x = x, y = 1, type = "bar"))
subplot(subplot(p[[1]], p[[2]], shareY = TRUE), p[[3]], shareY = TRUE)
Warning message:
In seq_len(nrows * unique(xAxisN)) :
  first element used of 'length.out' argument

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL