FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix error on clearing crosstalk selection by casperhart · Pull Request #2098 · plotly/plotly.R · GitHub

fix error on clearing crosstalk selection - #2098

Open
casperhart wants to merge 1 commit into
plotly:masterfrom
casperhart:crosstalk-selection-clear-bug
Open

fix error on clearing crosstalk selection#2098
casperhart wants to merge 1 commit into
plotly:masterfrom
casperhart:crosstalk-selection-clear-bug

Conversation

Copy link
Copy Markdown
Contributor

When linking plots using {crosstalk}, running selectionHandle.clear() from another (non-plotly) visual causes the following error to appear in the console and the selection in the plotly visual is not cleared:

This is because selectionHandle.clear() event passes an undefined value, which plotly isn't dealing with properly.

This PR fixes this issue.

Copy link
Copy Markdown
Collaborator

Thanks, can you please provide an example that demonstrates the fix?

casperhart force-pushed the crosstalk-selection-clear-bug branch from 393c960 to cd63424 Compare April 24, 2022 20:56

Copy link
Copy Markdown
Contributor Author

@cpsievert to reproduce, run the following in R:

library(crosstalk)
library(plotly)
library(DT)

data(iris)

shared_iris <- SharedData$new(iris)

a <- plot_ly(shared_iris, x = ~Sepal.Length, y = ~Sepal.Width) %>%
    add_markers() %>%
    highlight(on = "plotly_click", dynamic = TRUE)
b <- datatable(shared_iris)

bscols(
    list(
        filter_checkbox("species", "Species", shared_iris, ~Species)
    ),
    a, b 
)

Then select some points in the plotly visual, open up the browser console and run the following:

const handleId = Object.keys(__crosstalk_groups)[1]
const myHandle = new crosstalk.SelectionHandle(handleId)
myHandle.clear()

In the main branch code, this throws an error and the selection is not cleared. Using the version in this PR, no error is thrown and the crosstalk selection is successfully cleared.

Copy link
Copy Markdown

@cpsievert would it be possible to have a look at merging this fix? I ran into this issue today. Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL