Add valid attribute fill for trace type "box" - #2444
Open
oliver-gray wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@cpsievert @KasperSkytte Please could you take a look at this? Many thanks. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Some examples, tests, and more context would be helpful. Linking to any existing issues would also be appreciated. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "fill" attribute can be used in combination with the box trace type to provide colours to box plots. This is particularly useful to enable corroboration between traces of different types.
For example, between colours used for point/scatter traces and box traces.
This change sets fill as a valid attribute where thisTrace$type == "box".
Including this attribute as valid in the source .json file may be an alternative fix for the inaccurate/non-specific warning message.