fix: ggplotly() regressions - #2472
Open
cpsievert wants to merge 6 commits into
Open
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Cross-trace layout attributes like bargroupgap, boxgap, violinmode, etc. are not included in the plotly.js schema's layoutAttributes but are valid and work correctly. Added a comprehensive whitelist for bar/box/violin/ funnel/waterfall mode, gap, and groupgap attributes. Fixes #2458 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When using scale_color_manual() with custom labels, the legend entries now correctly display the scale labels instead of the raw domain values. This maps the trace names from the _plotlyDomain column values to their corresponding scale labels using get_breaks() and get_labels(). Fixes #2420 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
NA values in trace data (e.g., from geom_line gaps between groups) now correctly remain as NA when mapping categorical data back to ticktext labels. Previously, which.min() on NA values returned an empty vector which caused an indexing error. Fixes #2462 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The colorbar trace now preserves Date/POSIXct classes when computing x/y ranges. Previously, unlist() converted Date objects to numeric (days since epoch), which could confuse plotly.js axis handling. Changed to use do.call(c, ...) which preserves the original class. Fixes #2446 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor
|
Note that you should write Fixes #2458, fixes #2420, fixes #2462, fixes #2446 to close all of them when the PR is merged. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2458, #2420, #2462, #2446
🤖 Generated with Claude Code