Fix #2419, #2437: NA handling and subplot issues - #2473
Open
cpsievert wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Required for compatibility with newer gem versions from graphing-library-docs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix #2419: When hovertemplate was present and .plotlyVariableMapping length happened to equal row count, traceify() incorrectly subsetted it like data, breaking group2NA() NA insertion for line gaps. Now saves .plotlyVariableMapping before traceify and restores after. - Fix #2437: subplot() with pie charts created NA-named layout attributes because pie charts lack cartesian axes. Now checks if axes exist before extracting; returns empty list for plots without axes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue with NA handling in scatter plots: Two NAs per category cause incorrect line connection #2419: When hovertemplate was present and .plotlyVariableMapping length happened to equal the row count, traceify() incorrectly subsetted it like data columns, breaking group2NA() NA insertion for line gaps. Now saves .plotlyVariableMapping before traceify() and restores it to all traces afterward.
Fix subplot() with bar and pie chart creates unnecessary attribute and warning #2437: subplot() with pie charts created NA-named layout attributes because pie charts lack cartesian axes. Extracting non-existent axes from layout returned NA-named list elements. Now checks if axes exist before extracting and returns empty list for plots without axes.
🤖 Generated with Claude Code