FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Windows path handling in save_image() by cpsievert · Pull Request #2487 · plotly/plotly.R · GitHub

Fix Windows path handling in save_image() - #2487

Merged
cpsievert merged 6 commits into
masterfrom
fix-save-image-windows-paths
Apr 16, 2026
Merged

Fix Windows path handling in save_image()#2487
cpsievert merged 6 commits into
masterfrom
fix-save-image-windows-paths

Conversation

Copy link
Copy Markdown
Collaborator

Summary

  • add a regression test that captures the Windows temp-path interpolation bug in the Kaleido codepath
  • stop embedding file paths directly into Python source passed to reticulate
  • apply the safer path handoff to both the Kaleido v1 and legacy codepaths

Closes #2483.

Testing

  • R -q -e "devtools::test(filter = 'kaleido')"

This comment was marked as resolved.

This comment was marked as resolved.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cpsievert merged commit b8f8d96 into master Apr 16, 2026
14 checks passed
cpsievert deleted the fix-save-image-windows-paths branch April 16, 2026 21:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

save_image not working under windows

2 participants


Back | FazBrowse Home | New Git URL