| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good! I left a few small syntax suggestions, but it's good to go as is.
Sorry, something went wrong.
|
Hi @emilykl, |
Sorry, something went wrong.
|
@archmoj Thanks for the catch -- I've added a draftlog! It's a good point that this is a backward-incompatible change and so strictly speaking should only be introduced in a major version. I'm not psyched about bumping the version number just for this change, but perhaps there are a few other changes we could introduce at the same time. On the other hand, do you know if there are instances in the past where we've made an exception and introduced a change in a minor version? |
Sorry, something went wrong.
No I don't recall. Since v1 we tried to introduce breaking changes in major versions only. |
Sorry, something went wrong.
|
Note: Holding off on merging this PR until v4 release |
Sorry, something went wrong.
|
A related change that we've talked about a bit, and would be nice to get in alongside this if we're including it in a major release: making a small adjustment to the ranges of one or both of the axes with synced ticks so that the tick values are more precise and (hopefully) need fewer digits displayed. |
Sorry, something went wrong.
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
There was a problem hiding this comment.
Looks good. You just need to commit the updated types.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Closes #7683
This PR slightly modifies the default tickmode logic, such that tickmode defaults to 'sync' rather than 'auto' for overlaying axes. Motivation is explained in the linked issue.
Note: One case is excluded: When the overlaying axis is categorical (or multicategory), tickmode continues to default to 'auto' rather than 'sync', as 'sync' causes unexpected behavior with categorical axes and is probably never intended by the user.
This PR also fixes a bug where showexponent/showtickprefix/showticksuffix values of 'first' or 'last' did not render exponents/prefixes/suffixes on overlaid axes set to sync.