Add hoversort option - #7734
Merged
emilykl merged 5 commits intoMay 14, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
kimsehwan96
marked this pull request as draft
March 27, 2026 10:17
kimsehwan96
marked this pull request as ready for review
March 29, 2026 02:25
Copy link
Copy Markdown
Contributor
|
Thanks for the PR! One of our team members will review and follow up with you. |
Sorry, something went wrong.
emilykl
reviewed
May 14, 2026
Comment thread
test/jasmine/tests/fx_test.js
Outdated
emilykl
approved these changes
May 14, 2026
emilykl
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for your patience awaiting review, @kimsehwan96 ! This looks great, thank you for adding detailed test cases.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@emilykl Thanks for your review and works! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #5362
Adds a hoversort layout attribute that lets you sort items in unified hover labels by value.
hoversort: 'trace'
hoversort: 'value descending'
hoversort: 'value ascending'