fix: Handle 'pixel' size mode for shape labels - #7790
Merged
camdecoster merged 9 commits intoMay 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The initial mock validation failed because one of the shape types was listed as "rectangle", which isn't valid. "rect" is what should have been listed. I didn't notice this because the default shape used when an invalid type is passed in is... "rect". Thanks CI, for keeping us honest. |
Sorry, something went wrong.
camdecoster
marked this pull request as ready for review
May 1, 2026 22:16
emilykl
reviewed
May 7, 2026
Comment thread
src/components/shapes/display_labels.js
emilykl
reviewed
May 7, 2026
Comment thread
test/image/baselines/shape_label_pixel_sizemode.png
Outdated
emilykl
previously approved these changes
May 7, 2026
emilykl
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@camdecoster Looks good as-is, left a couple comments with suggestions
Sorry, something went wrong.
emilykl
approved these changes
May 8, 2026
emilykl
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🎉
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update shape label positioning logic to handle pixel size mode.
Closes #7749.
Changes
Screenshots
Testing