Add origin as query string to requests to plotlyServerURL - #7854
Merged
emilykl merged 3 commits intoJun 30, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
emilykl
reviewed
Jun 19, 2026
Comment thread
src/plots/plots.js
Outdated
emilykl
approved these changes
Jun 26, 2026
emilykl
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good!
Sorry, something went wrong.
emilykl
requested changes
Jun 26, 2026
emilykl
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Oh wait, @marthacryan can you update the should open URL in a new tab after clicking confirm button Jasmine test to reflect this change?
Code looks good, so after that it should be good to merge!
Sorry, something went wrong.
emilykl
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For secure communication between tabs via postMessage (after clicking the "upload to cloud" button), we need to include the origin of the request as a query string.