| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Thanks for the fix! The solution looks right to me, but you'll need to add the missing paren to get CI to complete. Could you also please add a test for this situation?
Sorry, something went wrong.
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
| Back | FazBrowse Home | New Git URL |
Problem
For vertical Sankey traces (orientation: 'v'), user-supplied node.x / node.y are normalized against the wrong extent. The d3-sankey layout space always carries the flow along its x axis, but for vertical orientation that space is transposed onto the screen. When the plotting area is non-square, nodes are placed outside the bounding box and the values written back after a drag can exceed the documented [0, 1] range.
Root cause
In src/traces/sankey/render.js, sankeyModel():
The user coordinates at (2) are scaled by the un-transposed extents, while the d3-sankey layout at (1) uses the transposed extents. The same asymmetry exists in the write-back path persistFinalNodePositions().
Fix
Closes #7947