Fix numeric color sorting in parcats bundles - #7959
Conversation
Sorry, something went wrong.
camdecoster
left a comment
There was a problem hiding this comment.
This looks like a good fix to me! I left one comment for you to consider. After that's resolved, I'll approve.
Sorry, something went wrong.
| } | ||
|
|
||
| return a.length - b.length; | ||
| } |
There was a problem hiding this comment.
What do you think of adding a JSDoc comment and a block to handle NaN values? This likely wouldn't happen in practice, but it could.
| } | |
| /** | |
| * Compare two sort arrays element by element in ascending order. | |
| * Values that do not order against each other, for example NaN, sort last. | |
| * The shorter array sorts first when one array is a prefix of the other. | |
| * | |
| * @param {Array} a | |
| * @param {Array} b | |
| */ | |
| function compareArrays(a, b) { | |
| for (let i = 0; i < Math.min(a.length, b.length); i++) { | |
| const valA = a[i]; | |
| const valB = b[i]; | |
| if (valA < valB) return -1; | |
| if (valA > valB) return 1; | |
| // Handle values that do not order against each other (NaN, undefined, etc.) | |
| if (valA !== valB) { | |
| // Sort these after every orderable value. | |
| const badA = isNaN(valA); | |
| const badB = isNaN(valB); | |
| if (badA !== badB) return badA ? 1 : -1; | |
| } | |
| } | |
| return a.length - b.length; | |
| } |
Sorry, something went wrong.
Per review suggestion from camdecoster: - Add JSDoc comment documenting ascending-order comparison, NaN-sorting behavior, and prefix handling. - Handle values that do not order against each other (NaN, undefined) by sorting them after every orderable value. - Add test verifying NaN color values sort after orderable values in bundled parallel-categories paths. The 4 pre-existing drag/reorder test failures are unchanged by this commit (27->28 passing, same 4 baseline failures).
|
Thanks @camdecoster for the suggestion! I've implemented it in commit \�ec4e475:
The new test and the existing numeric-color test both pass. The 4 pre-existing drag/reorder test failures are unchanged by this commit (they fail identically on the prior head). |
Sorry, something went wrong.
camdecoster
left a comment
There was a problem hiding this comment.
Looks good!
Sorry, something went wrong.
Closes #7952.
When bundlecolors is enabled, the parcats path sorter prepends each path's raw color to an array of category indices, then compares those arrays with JavaScript's < and > operators. That coerces the arrays to comma-separated strings, so numeric colors such as 1, 10, 2, 20 are ordered lexicographically.
This change compares the sort arrays element by element. Numeric colors now retain numeric order, while display-category indices and the existing value-index tie-breaker keep their current roles. A browser regression test renders a bundled parcats trace and checks the resulting path view-model order.
Verification:
The repository does not define a type-check script. The Windows test-syntax and full build commands also hit an existing glob portability problem (0 source files found), so I am relying on the successful CI build above and the repository's hosted CI for those Linux gates.
AI assistance disclosure: This contribution was developed and tested with OpenAI Codex. The implementation, regression coverage, and observed command results are disclosed above.