Update plotly.js to v4.0.0-rc.0 - #5673
Conversation
Sorry, something went wrong.
camdecoster
left a comment
There was a problem hiding this comment.
- Could we update the docs separately to keep things tidy?
- I think we can remove the Stream deprecation warning in _deprecations.py
- I still see a lot of references to linkText/link_text and showLink/show_link. Could those be removed?
- ColorValidator will need to be updated per the v4 changes
Sorry, something went wrong.
There was a problem hiding this comment.
ColorValidator will need to be updated to remove the references and regex checks for hsv since that got removed. The regex patterns will also need to be updated to match the new color specifier support.
Sorry, something went wrong.
Yes, as long as you're OK with the docs build failing on this PR. I'll split the docs changes into a separate PR.
👍 will do, thanks |
Sorry, something went wrong.
| @@ -28,26 +28,58 @@ def validator_aok_colorscale(): | |||
| ) | |||
|
|
|||
|
|
|||
| VALID_COLORS = [ | |||
There was a problem hiding this comment.
@camdecoster I tried to be pretty comprehensive here, but please suggest any formats I've missed. Likewise for the invalid colors list.
Sorry, something went wrong.
camdecoster
left a comment
There was a problem hiding this comment.
Looks good!
Sorry, something went wrong.
Description of change
Note: The failing plotly.js dev build CI job can be ignored. That job runs the tests after pulling dist/plotly.js from the plotly.js master branch, so naturally it will fail since the plotly.js v4.0 changes are not yet on master.
The failing docs build can also be ignored; it will fail until the docs are updated to remove mapbox code, which will be in a separate PR.
Notes
Closes #4824 due to the color library update in plotly.js v4.0.0.
Closes #5081 by removing all Mapbox references.