FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add Cmd/Ctrl+Shift+C keyboard shortcut to open compile window by haruo-gabriel · Pull Request #2387 · plugdata-team/plugdata · GitHub

/ plugdata Public

feat: add Cmd/Ctrl+Shift+C keyboard shortcut to open compile window - #2387

Open
haruo-gabriel wants to merge 1 commit into
plugdata-team:developfrom
haruo-gabriel:feature/compile-keyboard-shortcut
ConversationCommits (1)ChecksFiles changed
Open

feat: add Cmd/Ctrl+Shift+C keyboard shortcut to open compile window#2387
haruo-gabriel wants to merge 1 commit into
plugdata-team:developfrom
haruo-gabriel:feature/compile-keyboard-shortcut

Conversation

haruo-gabriel commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Description

This PR adds the Cmd/Ctrl + Shift + C keyboard shortcut to trigger the compile export dialog when compile mode is enabled.

The shortcut choice must be validated.

Related to issue #2344

Changes

  • Source/Constants.h: Registered new command ID CommandIDs::Compile
  • Source/PluginEditor.cpp:
    • Registered command metadata, default keypress combination Cmd/Ctrl + Shift + C, and conditional active state based on hvcc_mode (SettingsFile::getInstance()->getProperty<bool>("hvcc_mode")) in getCommandInfo
    • Wired command execution to open the Heavy export dialog via Dialogs::showHeavyExportDialog(&openedDialog, this) in perform
  • Source/Dialogs/MainMenu.h: Updated Main Menu Compile item state (isActive) to dynamically match hvccModeEnabled

What I've tested

Tested on Windows 11 only. Needs more testing on Mac and Linux!

  1. Compiled Mode ON:
    • Enabled Compiled Mode in settings/menu.
    • Pressed Cmd/Ctrl + Shift + C.
    • Result: The Heavy export dialog opens immediately.
  2. Compiled Mode OFF:
    • Disabled Compiled Mode in settings/menu.
    • Pressed Cmd/Ctrl + Shift + C.
    • Result: Emits a system alert sound (on Windows).
  3. Option Persistence:
    • Opened Heavy export dialog using Cmd/Ctrl + Shift + C.
    • Modified compiler options.
    • Closed the dialog and re-opened it using Cmd/Ctrl + Shift + C.
    • Result: All user-selected compiler settings and options remain preserved without resetting.

Next steps

  • Maybe add a shortcut to export without the need to open the compile window?

Copilot AI lite review requested due to automatic review settings August 27, 2026 21:43
Copilot AI reviewed Aug 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Adds a new application command for opening the Heavy compile/export dialog and binds it to a default Cmd/Ctrl+Shift+C shortcut, intended to be available only when “Compiled Mode” (hvcc_mode) is enabled.

Changes:

  • Added CommandIDs::Compile to the command ID enum.
  • Registered command metadata + default keypress and wired perform() to open the Heavy export dialog.
  • Updated the Main Menu “Compile…” item’s active state to track hvcc_mode.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
Source/PluginEditor.cpp Adds the new Compile command, default shortcut (Cmd/Ctrl+Shift+C), and performs dialog launch.
Source/Dialogs/MainMenu.h Attempts to disable/enable the “Compile…” menu item based on hvcc_mode.
Source/Constants.h Adds CommandIDs::Compile to the command ID list.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Source/Dialogs/MainMenu.h
Comment on lines 104 to 109
menuItems[getMenuItemIndex(MenuItem::Save)]->isActive = hasCanvas;
menuItems[getMenuItemIndex(MenuItem::SaveAs)]->isActive = hasCanvas;

menuItems[getMenuItemIndex(MenuItem::CompiledMode)]->isTicked = hvccModeEnabled;
menuItems[getMenuItemIndex(MenuItem::Compile)]->isActive = hvccModeEnabled;
}
Comment thread Source/PluginEditor.cpp
Comment on lines +1925 to +1928
case CommandIDs::Compile: {
Dialogs::showHeavyExportDialog(&openedDialog, this);
return true;
}

timothyschoen commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Cool, thanks for picking up this issue!

I'm not sure yet about the change that you can only open the compile menu when compiled mode is on: that may be too restrictive, and it may be unclear to new users why they cannot open the compile menu

dromer commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

If we also include a quick button then it would make sense that it only appears when compiled-mode is active. Otherwise the popup menu could still appear even outside of compiled-mode, since this mode is mainly meant for producing warnings and modifying the quick object browser. And you can also still activate it from the menu when the mode is not active.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL