FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: drop python2 by patrick96 · Pull Request #1908 · polybar/polybar · GitHub

/ polybar Public

build: drop python2 - #1908

Merged
patrick96 merged 1 commit into
polybar:masterfrom
patrick96:issue/1892
Oct 26, 2019
ConversationCommits (1)ChecksFiles changed
Merged

build: drop python2#1908
patrick96 merged 1 commit into
polybar:masterfrom
patrick96:issue/1892

Conversation

patrick96 commented Oct 22, 2019

Copy link
Copy Markdown
Member

Ref: polybar/xpp#17
Fixes #1892

Release notes: All mentions of python2 can be removed from the wiki.
The polybar PKGBUILD can be updated.

patrick96 requested a review from Lomadriel October 22, 2019 08:38
Lomadriel requested changes Oct 22, 2019
View reviewed changes

Lomadriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think the contrib files should all be updated for the future release no?
Like this one or the non git version of polybar in AUR.
https://github.com/polybar/polybar/blob/master/contrib/rpm/polybar.spec

patrick96 commented Oct 22, 2019

Copy link
Copy Markdown
Member Author

We generally update the non-git build files after the release because they need the new sha256 value and also right now the non-git version (3.4.0) still requires python2. As for the rpm spec @jubalh said he would maintain that file, so I'm not going to update that (also I wouldn't have a system to test that on)

patrick96 requested a review from Lomadriel October 22, 2019 21:50
Lomadriel approved these changes Oct 26, 2019
View reviewed changes

Lomadriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Okay

patrick96 merged commit a77923e into polybar:master Oct 26, 2019
patrick96 deleted the issue/1892 branch October 26, 2019 20:29
patrick96 mentioned this pull request Oct 28, 2019
Merged
patrick96 added a commit to patrick96/polybar that referenced this pull request Oct 28, 2019
Release 3.4.1
ba50ba6 
Changelog
Dependencies

We dropped `python2` as a dependency, just in time for its EOL. Now the only python dependency is `python3` (polybar#1908).

Fixes

* ipc:
    * Update bar when making it visible (polybar#1889), see polybar#1875
    * Set bar position when making it visible (polybar#1901), see polybar#1484, i3/i3#3834
* `internal/backlight`: Use correct brightness file for `amdgpu_bl0` (polybar#1900), see polybar#1870, Alexays/Waybar#335
* build: Compilation error under gcc7 (polybar#1910)
patrick96 added a commit to patrick96/polybar that referenced this pull request Oct 29, 2019
Release 3.4.1
73eae35 
Changelog

Dependencies:

We dropped `python2` as a dependency, just in time for its EOL. Now the only python dependency is `python3` (polybar#1908).

Fixes:

* ipc:
    * Update bar when making it visible (polybar#1889), see polybar#1875
    * Set bar position when making it visible (polybar#1901), see polybar#1484, i3/i3#3834
* `internal/backlight`: Use correct brightness file for `amdgpu_bl0` (polybar#1900), see polybar#1870, Alexays/Waybar#335
patrick96 added a commit that referenced this pull request Oct 30, 2019
Release 3.4.1
f08a593 
Changelog

Dependencies:

We dropped `python2` as a dependency, just in time for its EOL. Now the only python dependency is `python3` (#1908).

Fixes:

* ipc:
    * Update bar when making it visible (#1889), see #1875
    * Set bar position when making it visible (#1901), see #1484, i3/i3#3834
* `internal/backlight`: Use correct brightness file for `amdgpu_bl0` (#1900), see #1870, Alexays/Waybar#335

jubalh commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

Thanks for the ping. I created #1928 to update the spec file.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Lomadriel Lomadriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

python2 will be unmaintaned soon

3 participants

Back | FazBrowse Home | New Git URL