FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Release 3.4.2 by patrick96 · Pull Request #1964 · polybar/polybar · GitHub

Release 3.4.2 - #1964

Merged
patrick96 merged 7 commits into
polybar:3.4from
patrick96:release/3.4.2
Dec 27, 2019
Merged

Release 3.4.2#1964
patrick96 merged 7 commits into
polybar:3.4from
patrick96:release/3.4.2

Conversation

patrick96 commented Dec 23, 2019
edited
Loading

Copy link
Copy Markdown
Member

I think the fix for the block alignment in the renderer deserves a new patch release. This release includes the commits from the PRs #1893, #1936, #1951, #1967, and polybar/xpp#20

The release draft is here.

EDIT: I have also pulled the fixes for gcc10

Lomadriel and others added 7 commits December 23, 2019 17:09
The issue was that it used the position of the center module to
calculate the leftmost possible position of the block. However, if the
center module is empty that position is disastrously wrong.

Fixes polybar#591
Fixes polybar#1903
Before it did not take into account borders or a tray on the left.
It also sometimes rendered the gradient way to large
The old code didn't really work when the right block was pushing against
the center block. Also `fixed-center` wasn't properly defined. I have
now fixed it to the following:

* `fixed-center = true`: The center block stays at the center of the bar
whenever possible. It can be pushed to the left if the right block takes
too much space and to the right if the left block takes too much space
* `fixed-center = false`: The center block will be in the middle between
the left and right block whenever possible. If there is not enough space
between those two, the center block will be directly to the right of the
left block and pushes out the right block
Before, if the command produced no output, the `m_output` field would
not have been overwritten and the old output was displayed.

But since this is an explicit trigger of the hook, the user would expect
the output to be updated to whatever the script produces (even if that
is nothing).

Ref: https://www.reddit.com/r/Polybar/comments/e9a8ww
This is dependent on a PR to xpp that does the same. Newer compilers
(GCC10 in particular) are stricter about which headers provide the
std exception types.
Fixes

* `internal/i3` (and maybe others): Workspace icon map misbehaves for empty icon (polybar#1893), see polybar#1881
* `custom/ipc`: Clear content if hook produces no output. (polybar#1951)
* renderer:
    * The modules on the right no longer overlap the tray or are shifted out of the bar. (polybar#1936), see polybar#591, polybar#1903, polybar#1838, polybar#1236
    * The gradient when modules are shifted out of the bar (because there is not enough space) is now drawn correctly in all circumstances. (polybar#1936)
* build: Fixed a compilation issue in gcc10 (polybar#1967, polybar/xpp#20)
polybar deleted a comment from codecov Bot Dec 25, 2019
polybar deleted a comment from codecov Bot Dec 25, 2019
patrick96 requested a review from Lomadriel December 25, 2019 00:11

Lomadriel left a comment
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

I noticed that you introduces a branch release/3.4.2. Are we switching to the new branch model ?

Okay forget what I said.

patrick96 merged commit f7a1949 into polybar:3.4 Dec 27, 2019
patrick96 deleted the release/3.4.2 branch December 27, 2019 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL