FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

only exit on watch if stdin is TTY by ToppleTheNun · Pull Request #424 · postcss/postcss-cli · GitHub

  1. postcss
  2. postcss-cli

Repository navigation

only exit on watch if stdin is TTY - #424

Closed
ToppleTheNun wants to merge 1 commit into
postcss:masterfrom
ToppleTheNun:master
ConversationCommits (1)ChecksFiles changed
Closed

only exit on watch if stdin is TTY#424
ToppleTheNun wants to merge 1 commit into
postcss:masterfrom
ToppleTheNun:master

Conversation

ToppleTheNun commented Jan 18, 2022 •
edited
Loading

Copy link
Copy Markdown

check if stdin is TTY before checking "end" event,
as non-TTY stdin will always invoke end and exit.

found from running "postcss -w" in a docker container (#370)
and running "postcss -w" in lerna or turborepo.

closes #426

ToppleTheNun marked this pull request as ready for review January 18, 2022 13:13
RyanZim mentioned this pull request Jan 21, 2022
Closed

RyanZim commented Jan 21, 2022

Copy link
Copy Markdown
Collaborator

This causes tests to fail; please investigate.

exit watch on SIGINT instead of stdin end
1f3c99f 
stdin's end event is fired immediately if stdin is
not a TTY

toastal commented May 8, 2022

Copy link
Copy Markdown

Could be related to https://github.com/sindresorhus/get-stdin/blob/main/index.js#L4= short-circuit. Endemic to Node projects, there's no reason to be including a dependency for these 8 lines of code that come from process.stdin.

nickcluc commented Oct 12, 2022 •
edited
Loading

Copy link
Copy Markdown

Curious to know if this PR is dead? Running into this same issue with Rails-7 & postcss when we use foreman and background the foreman process. Thanks!

Note: the same fix here fixes that issue.

RyanZim commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

@nickcluc PR welcome that fixes this issue without breaking the test suite.

0xradical commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

Hi @RyanZim , this is my attempt at fixing this issue: #446.

RyanZim mentioned this pull request Nov 28, 2022
Closed
0xradical mentioned this pull request Nov 29, 2022
Merged
RyanZim closed this in #448 Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

postcss-cli 9.1.0 watch cannot be run without tty

5 participants

Back | FazBrowse Home | New Git URL