Don't fail silently when config not found - #471
Closed
kkmuffme wants to merge 2 commits into
Closed
kkmuffme wants to merge 2 commits into
kkmuffme wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Needs tests. Also should probably add an explanatory code comment, as it's a bit non-obvious what we're doing here. |
Sorry, something went wrong.
kkmuffme
force-pushed
the
throw-error-when-config-path-is-passed
branch
from
94eab51 to
7f1725b
Compare
January 17, 2024 11:51
Copy link
Copy Markdown
Contributor
Author
|
Added some tests and fixed an issue - could you approve the workflow? |
Sorry, something went wrong.
RyanZim
reviewed
Jan 17, 2024
Comment thread
test/cli.js
| t.is(await read(output), await read('test/fixtures/a.css')) | ||
| }) | ||
|
|
||
| test('fails on invalid explicit config', async (t) => { |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
This test should be moved to test/error.js
Sorry, something went wrong.
Comment thread
test/cli.js
| test('fails on invalid explicit config', async (t) => { | ||
| const output = tmp('output-ignore.css') | ||
|
|
||
| const { error, stderr } = await cli([ |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
We should verify that there's a non-zero exit code
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #467