Callback marks strings as Immutable - #24
Closed
AlejandroFrias wants to merge 2 commits into
Closed
AlejandroFrias wants to merge 2 commits into
AlejandroFrias wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
Coverage increased (+1.5%) to 82.353% when pulling 5195068 on AlejandroFrias:master into 9419f43 on ppannuto:master. |
Sorry, something went wrong.
1 similar comment
ppannuto
added a commit
that referenced
this pull request
May 19, 2017
Fix from @AlejandroFrias in #24, squashed and added a comment.
ppannuto
added a commit
that referenced
this pull request
May 19, 2017
* #24 from @AlejandroFrias: Mark callback strings immutable * #25 from @Garret-R: Handle dashes — unicode codepoints 2012 through 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
What do you think of this strategy? Anytime a word is added by a callback, we assume that user doesn't want it modified again, other than what the callback has done to it. So we mark it as immutable so that we won't modify it during the the SMALL_FIRST/SMALL_LAST step?