Add support for titlecasing non-ASCII letters - #46
Merged
ppannuto merged 4 commits intoApr 22, 2020
Merged
ppannuto merged 4 commits into
ppannuto merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Coverage remained the same at 82.278% when pulling 4aa3ad4 on acabal:master into 818f138 on ppannuto:master. |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
This is great, thanks so much! |
Sorry, something went wrong.
ppannuto
added a commit
that referenced
this pull request
Apr 22, 2020
Copy link
Copy Markdown
Contributor
Author
|
Any idea when the next version will be up on pypi? |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
Probably need to fix #50 first. I thought that pulling the version from setup was the canonical way to do things in Python, so that might take a second of googling for me to fix. |
Sorry, something went wrong.
ppannuto
added a commit
that referenced
this pull request
Jun 12, 2020
Lots of updates, thanks to one and all. This will be the last release with Py2k support and the last release before declaring a v1.0. Updates: - #35: Add fancy double quote to punctuation; Thanks @dwaynebailey! - #45: Fix deprecation warning regarding invalid escape sequences. Thanks @tirkarthi - #46: Add support for titlecasing non-ASCII letters; Thanks @acabal! - #47: Add sphinx documentation to titlecase function; Thanks @1kastner! - #49: Remove closing bracket in parser help text; Thanks @1kastner! - #53: Add table with examples; Thanks @1kastner! - #53: Terms with only consonants should be ALL CAPS; Thanks @Garret-R! - #54: setup.py: Read version from __init__.py to avoid importing the module Major thanks for unblocking this @iburago!!
brocksam
added a commit
to brocksam/python-titlecase
that referenced
this pull request
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests uses the regex pypi library to allow for titlecasing of non-ASCII characters. regex is a drop-in replacement for re so I simply replaced all instances of re for consistency.
Instead of checking for [a-zA-Z] in a regex, we instead check for Unicode properties like [\p{Letter}] or [\p{Uppercase_Letter}].