FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add default abbreviations by 1kastner · Pull Request #48 · ppannuto/python-titlecase · GitHub

Repository navigation

Add default abbreviations - #48

Merged
ppannuto merged 9 commits into
ppannuto:masterfrom
1kastner:patch-2
Jun 12, 2020
Merged

ppannuto merged 9 commits into
ppannuto:masterfrom
1kastner:patch-2

Conversation

Copy link
Copy Markdown
Contributor

The text file in the home directory contains one acronym per line. The style (capitals only, mixed, ...) is maintained.

coveralls commented Apr 22, 2020 •
edited
Loading

Copy link
Copy Markdown

Coverage increased (+2.2%) to 85.128% when pulling 6cd9132 on 1kastner:patch-2 into c89f1ee on ppannuto:master.

Copy link
Copy Markdown

Coverage decreased (-5.3%) to 77.011% when pulling 7934e58 on 1kastner:patch-2 into 818f138 on ppannuto:master.

Copy link
Copy Markdown
Contributor Author

Python 2 is officially sunset, so maybe the support could be dropped?

ppannuto left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you add some information to the README that documents:

  • the availability of the ~/.titlecase.txt feature
  • the expected format of the file
  • an example invocation

I think it would also be nice to expose an option to set a custom wordlist (i.e. titlecase --wordlist {path}), that would let folks have multiple lists depending on context, but more importantly, it's also a path to enabling the test suite to ship an example custom wordlist and run tests over that wordlist as well.


Re Py2k: No love here for Python2. I think what I'll probably do is try to shore up everything outstanding, make one last release that includes 2k, and then drop 2k with a new release -- probably actually make that a 1.0 release, which is way way past due given the use this sees.

Comment thread titlecase/__init__.py Outdated

Copy link
Copy Markdown
Contributor Author

Then let's wait for the new release without Python 2 for this merge.

Copy link
Copy Markdown
Owner

I made a few updates:

  • set this up to use the custom wordlist in all cases, not just command line invocation
  • added some tests to verify wordlist works as expected

Copy link
Copy Markdown
Contributor Author

@ppannuto anything you see still unaddressed?

Copy link
Copy Markdown
Owner

No I think this is ready. I need to resolve #50, make a last py2k release, then this can merge.

Figuring out install nonsense might have to wait till the weekend for me though

ppannuto and others added 7 commits June 12, 2020 12:04
The text file in the home directory contains one acronym per line. The style (capitals only, mixed, ...) is maintained.
Co-Authored-By: Pat Pannuto <pat.pannuto@gmail.com>
Explain .titlecase.txt usage
ppannuto added 2 commits June 12, 2020 12:26
Prior to py36, pathlib wouldn't implicitly convert
It's not that useful just to get at the home directory
ppannuto merged commit 73a949a into ppannuto:master Jun 12, 2020

Copy link
Copy Markdown
Owner

Thanks for implementing this, and for your patience!

ppannuto added a commit that referenced this pull request Jun 12, 2020
This adds support for user-customized wordlists (#48).
Thanks @1kastner!

Minor version changes:
 - This adds a new keyword argument to the `titlecase()` method.
 - This adds environment checks for a wordlist file in the home directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL